Introducing MRUSTC_LIB env variable (ref #214)
#287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catap
added a commit
to catap/mrustc
that referenced
this pull request
Aug 10, 2022
The idea is simple: we need some way to put `-latomic` to `gcc` call. Let add a dedicated variable which allows to add any library which may be needed. It may fixes: thepowersgang#287
The idea is simple: we need some way to put `-latomic` to `gcc` call. Let add a dedicated variable which allows to add any library which may be needed. It may fixes: thepowersgang#214
|
@thepowersgang I'd like to remind about this one |
|
I don't feel this should be a mrustc environment variable, maybe a minicargo one - but if this is required for a target, it should be added to the target spec. |
|
@thepowersgang but at some point of bootstrap minicargo is replaced to cargo, and such Or I've missed something? |
|
minicargo is used whenever mrustc is used. |
|
After thinking a while it seems like a bad approach. Let me close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is simple: we need some way to put
-latomictogcccall. Let add a dedicated variable which allows to add any library which may be needed.It fixes: #214